lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 11 Sep 2014 14:40:26 +0200
From:	Nikolay Aleksandrov <>
Subject: Re: [PATCH net-next 0/7] bonding: get rid of curr_slave_lock

On 11/09/14 13:38, Nikolay Aleksandrov wrote:
> Hi all,
> This is the second patch-set dealing with bond locking and the purpose here
> is to convert curr_slave_lock into a spinlock called "mode_lock" which can
> be used in the various modes for their specific needs. The first three
> patches cleanup the use of curr_slave_lock and prepare it for the
> conversion which is done in patch 4 and then the modes that were using
> their own locks are converted to use the new "mode_lock" giving us the
> opportunity to remove their locks.
> This patch-set has been tested in each mode by running enslave/release of
> slaves in parallel with traffic transmission and miimon=1 i.e. running
> all the time. In fact this lead to the discovery of a subtle bug related to
> RCU which will be fixed in -net.
> Also did an allmodconfig test just in case :-)
> Best regards,
>   Nikolay Aleksandrov
> Nikolay Aleksandrov (7):
>    bonding: 3ad: clean up curr_slave_lock usage
>    bonding: alb: remove curr_slave_lock
>    bonding: clean curr_slave_lock use
>    bonding: convert curr_slave_lock to a spinlock and rename it
>    bonding: alb: convert to bond->mode_lock
>    bonding: 3ad: convert to bond->mode_lock
>    bonding: adjust locking comments
>   drivers/net/bonding/bond_3ad.c     |  76 ++++++------------
>   drivers/net/bonding/bond_3ad.h     |   1 -
>   drivers/net/bonding/bond_alb.c     | 159 +++++++++----------------------------
>   drivers/net/bonding/bond_alb.h     |   2 -
>   drivers/net/bonding/bond_debugfs.c |   4 +-
>   drivers/net/bonding/bond_main.c    |  89 ++++-----------------
>   drivers/net/bonding/bond_options.c |  10 +--
>   drivers/net/bonding/bonding.h      |  16 ++--
>   8 files changed, 89 insertions(+), 268 deletions(-)
Self-NAK, I've missed one obvious spot in the 3ad state machine handler that 
also uses lag_ports instead of the slave list and needs to be fixed.

Anyhow, I'll wait until tonight before submitting v2 with the fix to see if 
there're any other comments.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists