netdev - Re: [PATCH] net: rfkill: gpio: Enable module auto-loading for ACPI based switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <277E9FBD-4284-44F4-896C-5A1D8E5E6814@holtmann.org>
Date:	Fri, 12 Sep 2014 12:46:49 -0700
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: rfkill: gpio: Enable module auto-loading for ACPI based switches

Hi Johannes,

> The switches that are enumerated over ACPI require a MODULE_ALIAS to
> allow auto-loading of the module.
> 
> Signed-off-by: Marcel Holtmann <marcel@...tmann.org>
> ---
> net/rfkill/rfkill-gpio.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
> 
> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
> index 02a86a27fd84..35e659392209 100644
> --- a/net/rfkill/rfkill-gpio.c
> +++ b/net/rfkill/rfkill-gpio.c
> @@ -180,3 +180,12 @@ module_platform_driver(rfkill_gpio_driver);
> MODULE_DESCRIPTION("gpio rfkill");
> MODULE_AUTHOR("NVIDIA");
> MODULE_LICENSE("GPL");
> +
> +#ifdef CONFIG_ACPI
> +MODULE_ALIAS("acpi:BCM2E1A");
> +MODULE_ALIAS("acpi:BCM2E39");
> +MODULE_ALIAS("acpi:BCM2E3D");
> +MODULE_ALIAS("acpi:BCM2E64");
> +MODULE_ALIAS("acpi:BCM4752");
> +MODULE_ALIAS("acpi:LNV4752");
> +#endif

while this patch gets the job done, it is too complicated. We can just use MODULE_DEVICE_TABLE for it. I will send an updated version.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html