netdev - Re: [PATCH v2 3/4] net: stmmac: add support for Intel Quark X1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140912.181423.1831537443587796533.davem@davemloft.net>
Date:	Fri, 12 Sep 2014 18:14:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hock.leong.kweh@...el.com
Cc:	peppe.cavallaro@...com, rayagond@...avyalabs.com,
	vbridgers2013@...il.com, srinivas.kandagatla@...com, wens@...e.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	boon.leong.ong@...el.com
Subject: Re: [PATCH v2 3/4] net: stmmac: add support for Intel Quark X1000

From: Kweh Hock Leong <hock.leong.kweh@...el.com>
Date: Thu, 11 Sep 2014 16:38:39 +0800

> +		if ((!strcmp(quark_x1000_phy_info[i].board_name, board_name)) &&
> +		    quark_x1000_phy_info[i].pci_func_num == func_num)

It is entirely erroneous to identify a device by it's _PHYSICAL_ geographic
location on the PCI bus.

Please get rid of this PCI function number comparison and if necessary
find another means of identification.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html