netdev - Re: [PATCH] IB/ipoib: order:1 failure in ipoib_cm_alloc_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20140912.152022.1499599699035890349.davem@davemloft.net>
Date:	Fri, 12 Sep 2014 15:20:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	venkat.x.venkatsubra@...cle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] IB/ipoib: order:1 failure in ipoib_cm_alloc_rx_skb
 causes softlockup

From: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
Date: Fri, 12 Sep 2014 09:15:33 -0700

> @@ -61,6 +61,11 @@ enum ipoib_flush_level {
>  	IPOIB_FLUSH_HEAVY
>  };
>  
> +#ifdef max
> +#undef max
> +#endif
> +#define max(x, y) (((int)(x) > (int)(y)) ? x : y)
> +
>  enum {
>  	IPOIB_ENCAP_LEN		  = 4,
>  

This is insanely inappropriate.

Use the linux/kernel.h provided max() definition, there is no reason
to redefine your own version, ever.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html