netdev - Re: [PATCH] net: bpf: correctly handle errors in sk_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140913.173805.566607253438396851.davem@davemloft.net>
Date:	Sat, 13 Sep 2014 17:38:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sasha.levin@...cle.com
Cc:	ast@...mgrid.com, keescook@...omium.org,
	hannes@...essinduktion.org, dborkman@...hat.com,
	spender@...ecurity.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bpf: correctly handle errors in sk_attach_filter()

From: Sasha Levin <sasha.levin@...cle.com>
Date: Sat, 13 Sep 2014 00:06:30 -0400

> Commit "net: bpf: make eBPF interpreter images read-only" has changed bpf_prog
> to be vmalloc()ed but never handled some of the errors paths of the old code.
> 
> On error within sk_attach_filter (which userspace can easily trigger), we'd
> kfree() the vmalloc()ed memory, and leak the internal bpf_work_struct.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html