netdev - Re: [PATCH net-next 2/7] fou: Support for foo-over-udp RX path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140913.130931.328536126350755386.davem@davemloft.net>
Date:	Sat, 13 Sep 2014 13:09:31 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/7] fou: Support for foo-over-udp RX path

From: Tom Herbert <therbert@...gle.com>
Date: Thu, 11 Sep 2014 13:07:31 -0700

> +#if defined(CONFIG_NET_FOU) || defined(CONFIG_NET_FOU_MODULE)

"IS_ENABLED(NET_FOU)"

> +int fou_create(struct net *net, struct fou_cfg *cfg,
> +	       struct socket **sockp);
> +int fou_destroy(struct net *net, struct fou_cfg *cfg);
> +
> +#else
> +static inline int fou_create(struct net *net, struct fou_cfg *cfg,
> +			     struct socket **sockp)
> +{
> +	return 0;
> +}
> +
> +static inline int fou_destroy(struct net *net, struct fou_cfg *cfg)
> +{
> +	return 0;
> +}
> +
> +#endif

I see no uses of fou_{create,destroy}() outside of net/ipv4/fou.c which
is only built when NET_FOU is enabled.

Yet you have NOP helpers (which probably should be returning an error
instead of 0) and export the symbol, both of which seem unnecessary.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html