| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Sep 2014 18:33:57 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: John Fastabend <john.fastabend@...il.com>, Changli Gao <xiaosuo@...il.com> Cc: xiyou.wangcong@...il.com, davem@...emloft.net, jhs@...atatu.com, netdev@...r.kernel.org, paulmck@...ux.vnet.ibm.com, brouer@...hat.com Subject: Re: [net-next PATCH v5 16/16] net: sched: drop ingress qdisc lock On Fri, 2014-09-12 at 16:56 -0700, Eric Dumazet wrote: > On Fri, 2014-09-12 at 09:35 -0700, John Fastabend wrote: > > After the previous patches to make the filters RCU safe and > > support per cpu counters we can drop the qdisc lock around > > the ingress qdisc hook. > > > > This is possible because the ingress qdisc is a very basic > > qdisc and only updates stats and runs tc_classify. Its the > > simplest qdiscs we have. > > > > In order for the per-cpu counters to get invoked the > > ingress qdisc must set the LLQDISC flag. We could use per-cpu > > counters on all counters but it is only necessary when the > > qdisc lock is not held. > > > > Signed-off-by: John Fastabend <john.r.fastabend@...el.com> > > --- > > Acked-by: Eric Dumazet <edumazet@...gle.com> > > BTW, it might be time to revive the multiqueue patch for IFB, Changli Gao worked on this 5 years ago, but work was not completed. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists