netdev - Re: [PATCH net-next v2 1/4] openvswitch: refactor ovs flow extract API.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140913.164708.1690675945507354047.davem@davemloft.net>
Date:	Sat, 13 Sep 2014 16:47:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/4] openvswitch: refactor ovs flow extract
 API.

From: Pravin B Shelar <pshelar@...ira.com>
Date: Thu, 11 Sep 2014 16:28:04 -0700

> @@ -250,7 +251,7 @@ void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb)
>  	stats = this_cpu_ptr(dp->stats_percpu);
>  
>  	/* Extract flow from 'skb' into 'key'. */
> -	error = ovs_flow_extract(skb, p->port_no, &key);
> +	error = ovs_flow_key_extract(skb, &key);
>  	if (unlikely(error)) {
>  		kfree_skb(skb);
>  		return;
...
> @@ -611,5 +604,35 @@ int ovs_flow_extract(struct sk_buff *skb, u16 in_port, struct sw_flow_key *key)
>  		}
>  	}
>  
> +	OVS_CB(skb)->pkt_key = key;
>  	return 0;

Wow, have you really been putting pointers to kernel stack variables
into the SKB control block all this time?

That's error prone as well as asking for trouble.

Please adjust the code to not do this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html