netdev - Re: [PATCH v2 net-next 3/7] fou: Add GRO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140915.142227.385081853295017602.davem@davemloft.net>
Date:	Mon, 15 Sep 2014 14:22:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 3/7] fou: Add GRO support

From: Tom Herbert <therbert@...gle.com>
Date: Sun, 14 Sep 2014 20:07:59 -0700

> @@ -62,6 +64,70 @@ static int fou_udp_recv(struct sock *sk, struct sk_buff *skb)
>  					  sizeof(struct udphdr));
>  }
>  
> +static inline struct sk_buff **fou_gro_receive(struct sk_buff **head,
> +					       struct sk_buff *skb,
> +					       const struct net_offload
> +							     **offloads)

Please drop the "inline" in foo.c files and let the compiler decide.  And
then you won't need to split up the "offloads" variable declaration like
that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html