netdev - Re: [Patch net-next 5/5] net_sched: clean up tcindex_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpXSB4PvPuNV-RnsrV7Fv45rgOxy4ewk7poYYmqc-JEmoA@mail.gmail.com>
Date:	Mon, 15 Sep 2014 16:39:59 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	John Fastabend <john.r.fastabend@...el.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	john fastabend <john.fastabend@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next 5/5] net_sched: clean up tcindex_set_parms()

On Mon, Sep 15, 2014 at 3:09 PM, John Fastabend
<john.r.fastabend@...el.com> wrote:
> On 09/15/2014 02:06 PM, Cong Wang wrote:
>> -     if (r == &new_filter_result) {
>> -             f = kzalloc(sizeof(*f), GFP_KERNEL);
>> -             if (!f)
>> -                     goto errout_alloc;
>> -     }
>> -
>
> It was put here to avoid having logic to unwind the state when/if the
> malloc fails.
>

Right, some operation after that is not undoable so we have to keep it there.
So drop this one.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html