| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LFD.2.03.1409161540490.25290@solarflare.com> Date: Tue, 16 Sep 2014 16:05:56 +0100 From: Edward Cree <ecree@...arflare.com> To: Nikolay Aleksandrov <nikolay@...hat.com> CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, Ben Hutchings <ben@...adent.org.uk>, Shradha Shah <sshah@...arflare.com>, "Solarflare linux maintainers" <linux-net-drivers@...arflare.com> Subject: Re: [PATCH net] sfc: fix addr_list_lock spinlock use before init On Mon, 15 Sep 2014, Nikolay Aleksandrov wrote: > When the module is initializing the ports it may call a function that > uses addr_list_lock before register_netdevice() has been called for that > port i.e. addr_list_lock is still uninitialized. The function in > question is efx_farch_filter_sync_rx_mode(), now it looks pointless to call > it before the port has been registered so alter the reconfigure_mac > callbacks to check if the port has been registered using the existing > efx_dev_registered() macro. Weak NAK as this should really be done in efx_farch_filter_sync_rx_mode() rather than its callers. In fact it seems our out-of-tree driver has done this for a while but we forgot to upstream it, though curiously we did upstream the corresponding fix for EF10. Will follow up with a patch after sanity testing it. -- -Edward Cree -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists