netdev - Re: [net-next PATCH v2 4/4] net: sched: cls_fw: add missing tcf_exts_init call in fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54189D37.4050009@intel.com>
Date:	Tue, 16 Sep 2014 13:27:35 -0700
From:	John Fastabend <john.r.fastabend@...el.com>
To:	David Miller <davem@...emloft.net>, john.fastabend@...il.com
CC:	xiyou.wangcong@...il.com, eric.dumazet@...il.com,
	netdev@...r.kernel.org, jhs@...atatu.com
Subject: Re: [net-next PATCH v2 4/4] net: sched: cls_fw: add missing tcf_exts_init
 call in fw_change()

On 09/16/2014 01:00 PM, David Miller wrote:
> From: John Fastabend <john.fastabend@...il.com>
> Date: Mon, 15 Sep 2014 23:31:42 -0700
> 
>> When allocating a new structure we also need to call tcf_exts_init
>> to initialize exts.
>>
>> A follow up patch might be in order to remove some of this code
>> and do tcf_exts_assign(). With this we could remove the
>> tcf_exts_init/tcf_exts_change pattern for some of the classifiers.
>> As part of the future tcf_actions RCU series this will need to be
>> done. For now fix the call here.
>>
>> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> 
> Applied.

Great thanks. A couple more patches for cls_u32 coming next. I'm
fairly sure I broke the selector keys usage and the change filter
case is not completely RCU safe yet depending on the netlink
attributes.

Thanks!
John

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html