netdev - Re: [PATCH net] sfc: fix addr_list_lock spinlock use before init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140916.163357.1799289058951971945.davem@davemloft.net>
Date:	Tue, 16 Sep 2014 16:33:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ecree@...arflare.com
Cc:	nikolay@...hat.com, netdev@...r.kernel.org, ben@...adent.org.uk,
	sshah@...arflare.com, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net] sfc: fix addr_list_lock spinlock use before init

From: Edward Cree <ecree@...arflare.com>
Date: Tue, 16 Sep 2014 17:05:21 +0100

> Reported by Nikolay Aleksandrov.  In efx_init_port() we call
>  efx_mac_reconfigure() to work around a Falcon/A1 limitation, and this calls
>  efx_{arch}_filter_sync_rx_mode(), which takes the addr_list_lock; but this
>  lock is uninitialised, because we haven't called register_netdevice() yet.
> So, in efx_farch_filter_sync_rx_mode(), check efx_dev_registered() before
>  doing anything else.
> The EF10 equivalent, efx_ef10_filter_sync_rx_mode(), already has the
>  corresponding check.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> Tested-by: Nikolay Aleksandrov <nikolay@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html