netdev - Re: [Patch net-next v2 2/4] net: fec: add interrupt coalescence feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140916.164523.1376753359151264152.davem@davemloft.net>
Date:	Tue, 16 Sep 2014 16:45:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Frank.Li@...escale.com
Cc:	b38611@...escale.com, netdev@...r.kernel.org, lznuaa@...il.com,
	shawn.guo@...aro.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [Patch net-next v2 2/4] net: fec: add interrupt coalescence
 feature support

From: <Frank.Li@...escale.com>
Date: Wed, 17 Sep 2014 01:58:08 +0800

> +/* ENET interrupt coalescing macro define */
> +#define FEC_ITR_CLK_SEL		(0x1 << 30)
> +#define FEC_ITR_EN		(0x1 << 31)
> +#define FEC_ITR_ICFT(X)		((X & 0xFF) << 20)
> +#define FEC_ITR_ICTT(X)		((X) & 0xFFFF)
> +#define FEC_ITR_ICFT_DEFAULT	200  /* Set 200 frame count threshold */
> +#define FEC_ITR_ICTT_DEFAULT	1000 /* Set 1000us timer threshold */
 ...
> +static int
> +fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)

The size of these fields in the register determines the limitations of
the various parameters that this chip can support.

Therefore you must validate the user's request and signal an error if
the user asks for coalescing parameters that don't fit into those
fields.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html