netdev - Re: [PATCH v2] scsi: use 'depends' instead of 'select' for SCSI_FC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140916.165614.1047136442384470192.davem@davemloft.net>
Date:	Tue, 16 Sep 2014 16:56:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	rdunlap@...radead.org
Cc:	jbottomley@...allels.com, netdev@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH v2] scsi: use 'depends' instead of 'select' for
 SCSI_FC_ATTRS

From: Randy Dunlap <rdunlap@...radead.org>
Date: Tue, 16 Sep 2014 13:47:41 -0700

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> There are other kconfig symbols which use SCSI_FC_ATTRS.
> In order to maintain sanity and prevent kconfig warnings, change
> all of these from using 'select' to using 'depends on' so that
> proper symbol dependencies will be honored and circular depends
> problems will be avoided.
> This fixes kconfig warnings and build errors:
> 
> warning: (LIBFC && SCSI_IBMVFC && SCSI_QLA_FC && SCSI_LPFC && ZFCP && SCSI_BFA_FC && SCSI_CHELSIO_FCOE && FUSION_FC) selects SCSI_FC_ATTRS which has unmet direct dependencies (SCSI && NET)
> drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_event':
> drivers/scsi/scsi_transport_fc.c:543:7: error: 'scsi_nl_sock' undeclared (first use in this function)
> drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_vendor_event':
> drivers/scsi/scsi_transport_fc.c:611:7: error: 'scsi_nl_sock' undeclared (first use in this function)
> 
> Reported-by: Fengguang Wu <fengguang.wu@...el.com> [0-day test robot]
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Applied, thanks Randy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html