netdev - Re: bisected regression: 3c59x corrupts packets in 3.17-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Sep 2014 06:17:04 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Meelis Roos <mroos@...ux.ee>
Cc:	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>,
	netdev@...r.kernel.org,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: bisected regression: 3c59x corrupts packets in 3.17-rc5

On Tue, Sep 16, 2014 at 02:14:54AM +0300, Meelis Roos wrote:
> Somewhere between 3.17.0-rc3 and 3.17.0-rc5 I started seeing dropped ssh 
> connections to a couple of test servers with dual AthlonMP (32-bit) and 
> 3C90x family of NICs (3Com Corporation 3c980-C 10/100baseTX NIC 
> [Python-T] (rev 78) in one server and 3Com Corporation 3c905C-TX/TX-M 
> [Tornado] (rev 78) in the other server). Bisect leads to the following 
> commit:
> 
> 98ea232cf63961fad734cc8c5e07e8915ec73073 is the first bad commit
> commit 98ea232cf63961fad734cc8c5e07e8915ec73073
> Author: Neil Horman <nhorman@...driver.com>
> Date:   Thu Sep 4 06:13:38 2014 -0400
> 
>     3c59x: avoid panic in boomerang_start_xmit when finding page address:
>     ...
> 
> -- 
> Meelis Roos (mroos@...ux.ee)
> 
I'm guessing the above change has uncovered another bug, mostly likely an
exhaustion of dma space on your system.  Nothing in the transmit path there does
any error checking for successful dma mapping, which it really should.  I'd be
willing to be that any dma mapping error leads to a leak in the mapping table.
Does your system have an iommu, or does it use swiotlb?  If its the latter, can
you increase the swiotlb table space and see if that relieves the problem?  In
the interim, I'll start adding some error checking to the transmit path.

Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html