lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Sep 2014 18:43:51 -0400 From: Sowmini Varadhan <sowmini.varadhan@...cle.com> To: David L Stevens <david.stevens@...cle.com> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCHv5 net-next 3/3] sunvnet: generate ICMP PTMUD messages for smaller port MTUs On (09/17/14 16:49), David L Stevens wrote: > + > + rt = ip_route_output_key(dev_net(dev), &fl4); > + if (!IS_ERR(rt)) { As I've mentioned before, this layering violation makes me uneasy, so its benefits should be evaluated carefully. You will typically not be able to find an rt for packets coming here from any application that does not itself use/update the FIB, e.g., uspace based packet-injectors (PF_PACKET-based applications, intel dpdk-based uspace stacks etc.) --Sowmini -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists