netdev - Re: [PATCH iproute2] ip lib: Change timestamp to be shorter and on the same line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140916193850.4dec41e8@urahara>
Date:	Tue, 16 Sep 2014 19:38:50 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Vadim Kochan <vadim4j@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ip lib: Change timestamp to be shorter and on
 the same line

On Tue, 16 Sep 2014 12:58:06 +0300
Vadim Kochan <vadim4j@...il.com> wrote:

> Changed timestamp format to look like more logging info:
> 
> [Sep 01 20:56:11.853146]2: enp0s25: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default
>     link/ether 3c:97:0e:a3:86:2e brd ff:ff:ff:ff:ff:ff
> 
> Signed-off-by: Vadim Kochan <vadim4j@...il.com>
> ---
>  lib/utils.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/utils.c b/lib/utils.c
> index dc21567..03092ba 100644
> --- a/lib/utils.c
> +++ b/lib/utils.c
> @@ -772,14 +772,13 @@ __u8* hexstring_a2n(const char *str, __u8 *buf, int blen)
>  int print_timestamp(FILE *fp)
>  {
>  	struct timeval tv;
> -	char *tstr;
> +	char tstr[40] = {};
>  
>  	memset(&tv, 0, sizeof(tv));
>  	gettimeofday(&tv, NULL);
>  
> -	tstr = asctime(localtime(&tv.tv_sec));
> -	tstr[strlen(tstr)-1] = 0;
> -	fprintf(fp, "Timestamp: %s %ld usec\n", tstr, (long)tv.tv_usec);
> +	strftime(tstr, sizeof(tstr), "%b %d %H:%M:%S", localtime(&tv.tv_sec));
> +	fprintf(fp, "[%s.%ld]", tstr, (long)tv.tv_usec);
>  	return 0;
>  }
>  

I am loath to change the output format since people write scripts parsing
output. Maybe add a new flag option to choose format?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html