netdev - Re: [PATCH net] macvlan: allow to enqueue broadcast pkt on virtual device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411168172.26859.61.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 19 Sep 2014 16:09:32 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net] macvlan: allow to enqueue broadcast pkt on virtual
 device

On Fri, 2014-09-19 at 15:57 -0700, Cong Wang wrote:
> On Fri, Sep 19, 2014 at 3:44 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> >
> > Therefore, suggesting user to 'fix tx_queue_len' is totally wrong.
> 
> How about HTB? You said:
> 
> "Only when you want to have say HTB on the bonding, you might need to
> change tx_queue_len"

Again, what is your point ?

How is it relevant to this particular bug report ?

Don't you think people using HTB on a virtual device do not already know
its better to either :

- Not use the default pfifo on htb classes
- Increase device queue len on the device.

Its been like that since a decade. No changes are needed in bond driver.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html