netdev - Re: [PATCH net-next] bnx2x: set gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1411103373.7106.296.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 18 Sep 2014 22:09:33 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Ariel Elior <ariel.elior@...gic.com>
Subject: Re: [PATCH net-next] bnx2x: set gso_segs in LRO mode

On Thu, 2014-09-18 at 13:48 -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> In commits cbf1de72324a8 ("bnx2x: fix GRO parameters"), and
> ab5777d748302 ("bnx2x: Get gso_segs from FW")
> special care was taken for GRO mode.
> 
> We can also get proper gso_segs for LRO mode.
> 
> This helps to get proper values for these SNMP counters, which should
> count number of segments. This also helps qdisc_pkt_len_init() to better
> track packet sizes when ingress qdisc is in place.
> 
> IpExtInNoECTPkts                63458
> IpExtInECT0Pkts                 8772480
> IpExtInCEPkts                   1390713
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

Please disregard this patch. Its not needed, as bnx2x_gro_receive() is
called even in LRO mode...


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html