netdev - Re: [PATCH net] sparc: bpf_jit: fix support for ldx/stx mem and SKF_AD_VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140919.160200.48663669220936853.davem@davemloft.net>
Date:	Fri, 19 Sep 2014 16:02:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ast@...mgrid.com
Cc:	dborkman@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] sparc: bpf_jit: fix support for ldx/stx mem and
 SKF_AD_VLAN_TAG

From: Alexei Starovoitov <ast@...mgrid.com>
Date: Tue, 16 Sep 2014 18:32:58 -0700

> fix several issues in sparc BPF JIT compiler.
> 
> ldx/stx related:
> . classic BPF instructions that access mem[] slots were not setting
>   SEEN_MEM flag, so stack wasn't allocated. Fix that by advertising
>   correct flags
> 
> . LDX/STX instructions were missing SEEN_XREG, so register value
>   could have leaked to user space. Fix it.
> 
> . since stack for mem[] slots is allocated with 'sub %sp' instead
>   of 'save %sp', use %sp as base register instead of %fp.
> 
> . ldx mem[0] means first slot in classic BPF which should have
>   -4 offset instead of 0.
> 
> . sparc64 needs 2047 stack bias as per ABI to access stack
> 
> . emit_stmem() was using LD32I macro instead of ST32I
> 
> SKF_AD_VLAN_TAG* related:
> . SKF_AD_VLAN_TAG_PRESENT must return 1 or 0 instead of '> 0' or 0
>   as per classic BPF de facto standard
> 
> . SKF_AD_VLAN_TAG needs to mask the field correctly
> 
> Fixes: 2809a2087cc4 ("net: filter: Just In Time compiler for sparc")
> Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html