netdev - Re: [PATCH net-next 1/3] tcp: move logic out of tcp_v[64]_gso_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411261461.26859.105.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 20 Sep 2014 18:04:21 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] tcp: move logic out of
 tcp_v[64]_gso_send_check

On Sat, 2014-09-20 at 14:52 -0700, Tom Herbert wrote:
> In tcp_v[46]_gso_send_check the TCP checksum is initialized to the
> pseudo header checksum using __tcp_v[46]_send_check. We can move this
> logic into new tcp[46]_gso_segment functions to be done when
> ip_summed != CHECKSUM_PARTIAL (ip_summed == CHECKSUM_PARTIAL should be
> the common case, possibly always true when taking GSO path). After this
> change tcp_v[46]_gso_send_check is no-op.
> 
> Signed-off-by: Tom Herbert <therbert@...gle.com>
> ---
>  net/ipv4/tcp_offload.c   | 39 +++++++++++++++++++++++----------------
>  net/ipv6/tcpv6_offload.c | 37 ++++++++++++++++++++++++-------------
>  2 files changed, 47 insertions(+), 29 deletions(-)

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html