netdev - Re: [PATCH net-next 1/8] ipv6: support for fib6_clean_* to update fn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Sep 2014 12:09:24 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	YOSHIFUJI Hideaki <hideaki@...hifuji.org>, netdev@...r.kernel.org
Cc:	eric.dumazet@...il.com, vyasevich@...il.com,
	nicolas.dichtel@...nd.com, kafai@...com,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH net-next 1/8] ipv6: support for fib6_clean_* to update
 fn_sernum

On Sun, Sep 21, 2014, at 04:07, YOSHIFUJI Hideaki wrote:
> Hi,
> 
> Hannes Frederic Sowa wrote:
> 
> > @@ -71,7 +72,8 @@ static DEFINE_RWLOCK(fib6_walker_lock);
> >  #define FWS_INIT FWS_L
> >  #endif
> >  
> > -static void fib6_prune_clones(struct net *net, struct fib6_node *fn);
> > +static void fib6_prune_clones(struct net *net, struct fib6_node *fn,
> > +			      u32 sernum);
> >  static struct rt6_info *fib6_find_prefix(struct net *net, struct fib6_node *fn);
> >  static struct fib6_node *fib6_repair_tree(struct net *net, struct fib6_node *fn);
> >  static int fib6_walk(struct fib6_walker_t *w);
> > @@ -84,7 +86,7 @@ static int fib6_walk_continue(struct fib6_walker_t *w);
> >   *	result of redirects, path MTU changes, etc.
> >   */
> >  
> > -static __u32 rt_sernum;
> > +static u32 rt_sernum;
> >  
> >  static void fib6_gc_timer_cb(unsigned long arg);
> >  
> 
> I don't think you do really convert __u32 to u32
> in this series.

You're right there are some places left. I'll fix that up and resend. In
the end I'll convert the fn_sernum over to int to align with atomic_t.

Thanks,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html