netdev - Re: [PATCH net-next v2 2/2] enic: Add ethtool support to show classifier filters added by the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.03.1409220255370.26194@ws.cisco>
Date:	Mon, 22 Sep 2014 03:17:29 +0530 (IST)
From:	Govindarajulu Varadarajan <_govind@....com>
To:	Ben Hutchings <ben@...adent.org.uk>
cc:	Govindarajulu Varadarajan <_govind@....com>, davem@...emloft.net,
	netdev@...r.kernel.org, ssujith@...co.com, benve@...co.com
Subject: Re: [PATCH net-next v2 2/2] enic: Add ethtool support to show
 classifier filters added by the driver

On Sat, 6 Sep 2014, Ben Hutchings wrote:

> On Mon, 2014-07-21 at 17:22 +0530, Govindarajulu Varadarajan wrote:
>> This patch impliments ethtool_ops->get_rxnfc() to display the classifier
>> filter added by the driver.
> [...]
>
> ARFS and ethtool RXNFC are two different interfaces for setting filters
> and they shouldn't be confused with each other.
>
> In the sfc driver, I made the filters inserted through each interface
> invisible from the other.  The mlx4_en driver also appears to keep the
> two sets of filters separate.
>
> I can see that it is useful to be able to find out which filters have
> been inserted through ARFS, but it should be possible to distinguish
> them from those inserted through RXNFC.  Please don't include those
> filters when ETHTOOL_GRXCLSRLCNT or ETHTOOL_GRXCLSRLALL are used.
>
> Either add new command numbers for getting ARFS filters (the same
> structures will do), or define some kind of extension flag for this
> purpose.
>

Will work on adding new ethtool cmd with same infrastructure as RXNFC for
displaying filters added by ARFS, removing existing get_rxnfc for enic and
use new ethtool cmd.

Thanks for your feedback.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html