netdev - Re: [PATCH v3 net-next] tcp: avoid possible arithmetic overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1411417722.26859.154.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 22 Sep 2014 13:28:42 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	ycheng@...gle.com, joe@...ches.com, netdev@...r.kernel.org,
	ncardwell@...gle.com
Subject: Re: [PATCH v3 net-next] tcp: avoid possible arithmetic overflows

On Mon, 2014-09-22 at 16:27 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Mon, 22 Sep 2014 13:19:44 -0700
> 
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > icsk_rto is a 32bit field, and icsk_backoff can reach 15 by default,
> > or more if some sysctl (eg tcp_retries2) are changed.
> > 
> > Better use 64bit to perform icsk_rto << icsk_backoff operations
> > 
> > As Joe Perches suggested, add a helper for this.
> > 
> > Yuchung spotted the tcp_v4_err() case.
> > 
> > From: Eric Dumazet <edumazet@...gle.com>
> 
> I assume you meant "Signed-off-by: " on that last line, not "From: " :-)
> 
> Applied,

Arg, thanks David ;)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html