netdev - Re: [net-next PATCH 29/29] fm10k: Add support for PTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54203072.5070701@intel.com>
Date:	Mon, 22 Sep 2014 07:21:38 -0700
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	David Laight <David.Laight@...LAB.COM>,
	'Richard Cochran' <richardcochran@...il.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"john.fastabend@...il.com" <john.fastabend@...il.com>,
	"matthew.vick@...el.com" <matthew.vick@...el.com>,
	"jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [net-next PATCH 29/29] fm10k: Add support for PTP

On 09/22/2014 04:03 AM, David Laight wrote:
> From: Of Richard Cochran
>> On Thu, Sep 18, 2014 at 06:40:46PM -0400, Alexander Duyck wrote:
>>
>>> +static s32 fm10k_1588_msg_vf(struct fm10k_hw *hw, u32 **results,
>>> +			     struct fm10k_mbx_info *mbx)
>>> +{
>>> +	struct fm10k_intfc *interface = container_of(hw,
>>> +						     struct fm10k_intfc,
>>> +						     hw);
>>
>> This looks really funny to me here and in the other spot. Why not this?
>>
>> 	struct fm10k_intfc *interface = container_of(hw, struct fm10k_intfc, hw);
>>
>> Its only one over the 80 km/h speed limit.
> 
> Or split the assignment from the declaration.
> 
> 	David

That was the solution I went with.  It solved both the line over 80
characters and breaking up of the container_of parameter list.

Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html