netdev - Re: [PATCH net] ipv4: do not use this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411406901.26859.137.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 22 Sep 2014 10:28:21 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Tom Herbert <therbert@...gle.com>, joe9mail@...il.com
Subject: Re: [PATCH net] ipv4: do not use this_cpu_ptr() in preemptible
 context

On Mon, 2014-09-22 at 10:21 -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> this_cpu_ptr() in preemptible context is generally bad
> 
> Sep 22 05:05:55 br kernel: [   94.608310] BUG: using smp_processor_id() in
> preemptible [00000000] code: ip/2261
> Sep 22 05:05:55 br kernel: [   94.608316] caller is
> tunnel_dst_set.isra.28+0x20/0x60 [ip_tunnel]
> Sep 22 05:05:55 br kernel: [   94.608319] CPU: 3 PID: 2261 Comm: ip Not tainted
> 3.17.0-rc5 #82
> 
> We can simply use __this_cpu_ptr(), as preemption is safe in these contexts.
> 
> Should fix https://bugzilla.kernel.org/show_bug.cgi?id=84991
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Joe <joe9mail@...il.com>
> Fixes: 9a4aa9af447f ("ipv4: Use percpu Cache route in IP tunnels")
> ---

Hmm, I just saw raw_cpu_ptr() should be used.

I'll send a v2


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html