netdev - [PATCH net] tcp: Fix TLP implementation in case receive window limits send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Sep 2014 16:28:56 +0000
From:	Itzcak Pechtalt <itzcak@...shnetworks.com>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: [PATCH net] tcp: Fix TLP implementation in case receive window limits
 send

From: Itzcak Pechtalt <itzcak@...shnetworks.com>

TCP Tail loss probe (TLP) algorithm implementation has some problem.
According to paper (draft-dukkipati-tcpm-tcp-loss-probe-0 ):
In case recive window of receiver limits send of new packet in probe time than
a retransmit of last packet send should be done.

Actually, return code from tcp_write_xmit is not checked and only RTO is
scheduled,
So, it will take more time for reovery in this case than without TLP.

Signed-off-by: Itzcak Pechtalt <itzcak@...shnetworks.com>
---
net/ipv4/tcp_output.c  |    2 +-
1 file changed, 1 insertions(+),  1 deletions(-)

diff -up a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
--- a/net/ipv4/tcp_output.c     2014-09-23 18:35:37.113771694 +0300
+++ b/net/ipv4/tcp_output.c     2014-09-23 18:39:58.207726420 +0300
@@ -2100,7 +2100,8 @@ void tcp_send_loss_probe(struct sock *sk

        if (tcp_send_head(sk) != NULL) {
                err = tcp_write_xmit(sk, mss, TCP_NAGLE_OFF, 2, GFP_ATOMIC);
-              goto rearm_timer;
+             if (!err)
+                       goto rearm_timer;
        }

        /* At most one outstanding TLP retransmission. */

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html