netdev - Re: [PATCH v3 net-next 1/3] ipv4: rename ip_options_echo to __ip_options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411677008.3460.7.camel@joe-AO725>
Date:	Thu, 25 Sep 2014 13:30:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	Eric Dumazet <edumazet@...gle.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Yuchung Cheng <ycheng@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Christoph Paasch <christoph.paasch@...ouvain.be>
Subject: Re: [PATCH v3 net-next 1/3] ipv4: rename ip_options_echo to
 __ip_options_echo()

On Thu, 2014-09-25 at 13:14 -0700, Eric Dumazet wrote:
> ip_options_echo() assumes struct ip_options is provided in &IPCB(skb)->opt
> Lets break this assumption, but provide a helper to not change all call points.
[]
> diff --git a/include/net/ip.h b/include/net/ip.h
[]
> @@ -511,7 +513,14 @@ int ip_forward(struct sk_buff *skb);
>   
>  void ip_options_build(struct sk_buff *skb, struct ip_options *opt,
>  		      __be32 daddr, struct rtable *rt, int is_frag);
> -int ip_options_echo(struct ip_options *dopt, struct sk_buff *skb);
> +
> +int __ip_options_echo(struct ip_options *dopt, struct sk_buff *skb,
> +		      const struct ip_options *sopt);

Thanks Eric.

Unrelated:

I wonder how much effort, if any, should be made to convert
struct sk_buff * to const struct sk_buff * where appropriate.

For instance:

This __ip_options_echo could use const struct sk_buff *skb
if fib_compute_spec_dst was changed to const struct sk_buff *skb.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html