netdev - Re: [PATCH] net: fec: remove memory copy for rx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140926.170720.2230061639326332503.davem@davemloft.net>
Date:	Fri, 26 Sep 2014 17:07:20 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	b38611@...escale.com
Cc:	b20596@...escale.com, netdev@...r.kernel.org, shawn.guo@...aro.org,
	bhutchings@...arflare.com
Subject: Re: [PATCH] net: fec: remove memory copy for rx path

From: Fugang Duan <b38611@...escale.com>
Date: Wed, 24 Sep 2014 14:05:30 +0800

> Re-allocate skb instead of memory copy skb data in rx path to improve
> enet rx performance.
> 
> Signed-off-by: Fugang Duan <B38611@...escale.com>
> Signed-off-by: Frank Li <Frank.Li@...escale.com>

For small packet sizes, copying is almost certainly faster and it avoids
mismatched skb->truesize vs. skb->len which hurts TCP performance.

We call this rx_copybreak, and there are many drivers you can look at
to see how this works.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html