netdev - Re: [PATCH] Revert "net/macb: add pinctrl consumer support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3c8ab73-4dd5-436e-9647-c4a43e40c3a9@BL2FFO11FD051.protection.gbl>
Date:	Fri, 26 Sep 2014 13:06:20 -0700
From:	Sören Brinkmann <soren.brinkmann@...inx.com>
To:	David Miller <davem@...emloft.net>
CC:	<nicolas.ferre@...el.com>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] Revert "net/macb: add pinctrl consumer support"

On Fri, 2014-09-26 at 03:49PM -0400, David Miller wrote:
> From: Soren Brinkmann <soren.brinkmann@...inx.com>
> Date: Mon, 22 Sep 2014 16:49:08 -0700
> 
> > This reverts commit 8ef29f8aae524bd51298fb10ac6a5ce6c4c5a3d8.
> > The driver core already calls pinctrl_get() and claims the default
> > state. There is no need to replicate this in the driver.
> > ---
> > Hi,
> > 
> > I might be mistaken, but I think the driver core does already take care of
> > calling into the pinctrl framework and the driver does not need to do it on its
> > own (drivers/base/dd.c:really_probe() calls 'pinctrl_bind_pins() which takes
> > care of the pinctrl setup).
> > 
> 
> Applied and queued up for -stable, thanks.

thx

> Next time please provide a proper "Signed-off-by: " in the commit message
> of your submission.

Yeah, sorry for that. I overlooked that one. My alias for commit takes
care of this, but I don't have that for revert.

In case you need it:
Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com>

	Sören
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html