netdev - Re: [PATCH v3 5/7] net: Add GSO support for UDP tunnels with checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx-FqE70TROzxi=-B9DKaUsMs-=KZk3XbY7_qhOk3b2aNQ@mail.gmail.com>
Date:	Fri, 26 Sep 2014 14:57:28 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	Or Gerlitz <or.gerlitz@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 5/7] net: Add GSO support for UDP tunnels with checksum

On Fri, Sep 26, 2014 at 2:05 PM, Or Gerlitz <or.gerlitz@...il.com> wrote:
> On Thu, Jun 5, 2014 at 3:20 AM, Tom Herbert <therbert@...gle.com> wrote:
>>
>> Added a new netif feature for GSO_UDP_TUNNEL_CSUM. This indicates
>> that a device is capable of computing the UDP checksum in the
>> encapsulating header of a UDP tunnel.
>
>
>
> Tom,
>
> Do we have upstream driver that supports GSO_UDP_TUNNEL_CSUM? did you
> had such driver/patch while doing this patches? when a driver
> advertizes that bit, should they look over the xmit path on the new
> encap_hdr_csum bit?
>
No, no, and encap_hdr_csum should only be set with
SKB_GSO_UDP_TUNNEL_CSUM or SKB_GSO_GRE_CSUM.

find . -name '*.[ch]' -exec fgrep -l GSO_UDP_TUNNEL_CSUM {} \;

returns nothing.

find . -name '*.[ch]' -exec fgrep -l GSO_UDP_TUNNEL {} \;

returns

./ethernet/intel/i40e/i40e_main.c
./ethernet/broadcom/bnx2x/bnx2x_main.c
./ethernet/qlogic/qlcnic/qlcnic_main.c
./ethernet/mellanox/mlx4/en_netdev.c
./ethernet/emulex/benet/be_main.c

> Or.
>
>
>>
>>  include/linux/netdev_features.h |  1 +
>>  include/linux/skbuff.h          |  2 ++
>>  net/ipv4/af_inet.c              |  1 +
>>  net/ipv4/tcp_offload.c          |  1 +
>>  net/ipv4/udp.c                  | 40 +++++++++++++++++++---------------------
>>  net/ipv4/udp_offload.c          |  4 +++-
>>  net/ipv6/ip6_offload.c          |  1 +
>>  net/ipv6/udp_offload.c          |  4 +++-
>>  8 files changed, 31 insertions(+), 23 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html