lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 26 Sep 2014 10:35:32 +0200
From:	Jesper Dangaard Brouer <>
To:	Eric Dumazet <>
Cc:	David Miller <>,
	netdev <>, Amir Vadai <>,
	John Fastabend <>,
Subject: Re: [PATCH net-next] net: reorganize sk_buff for faster

On Thu, 25 Sep 2014 14:20:04 -0700
Eric Dumazet <> wrote:

> From: Eric Dumazet <>
> With proliferation of bit fields in sk_buff, __copy_skb_header() became
> quite expensive, showing as the most expensive function in a GSO
> workload.
> __copy_skb_header() performance is also critical for non GSO TCP
> operations, as it is used from skb_clone()
> This patch carefully moves all the fields that were not copied in a
> separate zone : cloned, nohdr, fclone, peeked, head_frag, xmit_more
> Then I moved all other fields and all other copied fields in a section
> delimited by headers_start[0]/headers_end[0] section so that we
> can use a single memcpy() call, inlined by compiler using long
> word load/stores.
> I also tried to make all copies in the natural orders of sk_buff,
> to help hardware prefetching.
> I made sure sk_buff size did not change.
> Signed-off-by: Eric Dumazet <>
> ---

I'm impressed, network ninja!

Acked-by: Jesper Dangaard Brouer <>

It would have been nice if you would have included the performance
improvement you saw, e.g. from:

Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists