netdev - Re: [RFC PATCH net-next] net: pktgen: packet bursting via skb->xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411850590.15768.6.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 27 Sep 2014 13:43:10 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	netdev@...r.kernel.org, Amir Vadai <amirv@...lanox.com>,
	Or Gerlitz <or.gerlitz@...il.com>
Subject: Re: [RFC PATCH net-next] net: pktgen: packet bursting via
 skb->xmit_more

On Fri, 2014-09-26 at 00:42 -0700, Eric Dumazet wrote:

> By the way with this patch, I now reach 10 Mpps on mlx4 
> 
> base line : 5 Mpps
> 
> + skb->xmit_more and quick hack in pjtgen (spinlock/unlock per packet)
> -> 7 Mpps
> 
> + burst of 16 packets, no spinlock per packet -> 10 Mpps

With careful study of mlx4 driver to remove false sharing, I now get 14
Mpps.

(Note they have a special feature to 'inline' small packets in tx
descriptors : If this is used, max rate is lower, because cpu spend more
cycles to perform the copies)

I find worrying driver authors do not know how to properly use a ring
buffer, and do not place the producer and consumer indexes in separate
cache lines.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html