lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Sep 2014 05:42:16 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Or Gerlitz <gerlitz.or@...il.com> Cc: Alexei Starovoitov <ast@...mgrid.com>, "David S. Miller" <davem@...emloft.net>, Jesper Dangaard Brouer <brouer@...hat.com>, Eric Dumazet <edumazet@...gle.com>, John Fastabend <john.r.fastabend@...el.com>, Linux Netdev List <netdev@...r.kernel.org>, Amir Vadai <amirv@...lanox.com>, Or Gerlitz <or.gerlitz@...il.com> Subject: Re: [PATCH net-next] mlx4: optimize xmit path On Sat, 2014-09-27 at 15:56 -0700, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@...gle.com> > > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > --- > > struct mlx4_en_tx_ring { > + /* cache line used and dirtied in tx completion > + * (mlx4_en_free_tx_buf()) > + */ > + u32 last_nr_txbb; > + u32 cons; > + > + /* cache line used and dirtied in mlx4_en_xmit() > + */ > + u32 prod ____cacheline_aligned_in_smp; > + unsigned long bytes; > + unsigned long packets; > + unsigned long tx_csum; > + struct mlx4_bf bf; > + unsigned long queue_stopped; > + unsigned long wake_queue; > + Hmm, I forgot to move wake_queue in the first cache line. I also forgot to include <linux/prefetch.h> I'll send a v2. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists