netdev - Re: [PATCH 33/34] netfilter: nf_tables: store and dump set policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54298583.3020100@cogentembedded.com>
Date:	Mon, 29 Sep 2014 20:14:59 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Pablo Neira Ayuso <pablo@...filter.org>,
	netfilter-devel@...r.kernel.org
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 33/34] netfilter: nf_tables: store and dump set policy

On 09/29/2014 04:39 PM, Pablo Neira Ayuso wrote:

> From: Arturo Borrero <arturo.borrero.glez@...il.com>

> We want to know in which cases the user explicitly sets the policy
> options. In that case, we also want to dump back the info.

> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@...il.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> ---
>   include/net/netfilter/nf_tables.h |    2 ++
>   net/netfilter/nf_tables_api.c     |    6 ++++++
>   2 files changed, 8 insertions(+)

> diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h
> index c4d8619..3d72923 100644
> --- a/include/net/netfilter/nf_tables.h
> +++ b/include/net/netfilter/nf_tables.h
[...]
> index a476b99..19e79f0 100644
> --- a/net/netfilter/nf_tables_api.c
> +++ b/net/netfilter/nf_tables_api.c
> @@ -2344,6 +2344,11 @@ static int nf_tables_fill_set(struct sk_buff *skb, const struct nft_ctx *ctx,
>   			goto nla_put_failure;
>   	}
>
> +	if (set->policy != NFT_SET_POL_PERFORMANCE) {
> +		if (nla_put_be32(skb, NFTA_SET_POLICY, htonl(set->policy)))
> +			goto nla_put_failure;

    Why not fold these two *if* stetement into a single one?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html