[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <90e56f4692144d77b9d1cee3a2cea667@BY2PR0301MB0711.namprd03.prod.outlook.com>
Date: Mon, 29 Sep 2014 03:51:32 +0000
From: KY Srinivasan <kys@...rosoft.com>
To: David Miller <davem@...emloft.net>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
"olaf@...fle.de" <olaf@...fle.de>,
"apw@...onical.com" <apw@...onical.com>,
"jasowang@...hat.com" <jasowang@...hat.com>,
"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 1/1] Drivers: net-next: hyperv: Fix a bug in
netvsc_start_xmit()
> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Sunday, September 28, 2014 8:17 PM
> To: KY Srinivasan
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> jasowang@...hat.com; stable@...r.kernel.org
> Subject: Re: [PATCH 1/1] Drivers: net-next: hyperv: Fix a bug in
> netvsc_start_xmit()
>
> From: "K. Y. Srinivasan" <kys@...rosoft.com>
> Date: Sun, 28 Sep 2014 19:49:51 -0700
>
> > After the packet is successfully sent, we should not touch the skb as
> > it may have been freed. This patch is based on the work done by Long
> > Li <longli@...rosoft.com>.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > Tested-by: Long Li <longli@...rosoft.com>
> > Cc: <stable@...r.kernel.org>
>
> You hyperv guys really have to get your act together. This is not properly
> submitted.
>
> Most importantly, this is a serious reference to free memory bug.
> Therefore it should be targetted at 'net' not 'net-next'.
>
> Secondly, you do not CC: stable for networking changes, you instead ask me
> to queue it up for my next batch of -stable networking changes.
>
> Thirdly, your Subject line is malformed. You should not use
> "Drivers: " as a prefix. Just the driver name is sufficient.
> You should also not mentionen the target GIT tree outside of the [PATCH ...]
> bracketed area.
>
> Also, please be cognizant of how much of my time you unnecessarily
> consume when you make a malformed submission like this. That is time I
> could spend reviewing other patches.
Sorry about that; I will resubmit this patch after addressing all the issues you have raised.
Regards,
K. Y
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists