netdev - Re: [PATCH v2 net-next] mlx4: optimize xmit path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1412014086.30721.36.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 29 Sep 2014 11:08:06 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	Or Gerlitz <gerlitz.or@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Amir Vadai <amirv@...lanox.com>,
	Or Gerlitz <or.gerlitz@...il.com>
Subject: Re: [PATCH v2 net-next] mlx4: optimize xmit path

On Mon, 2014-09-29 at 10:46 -0700, Alexei Starovoitov wrote:
> On Sun, Sep 28, 2014 at 9:19 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> >         send_doorbell = !skb->xmit_more || netif_xmit_stopped(ring->tx_queue);
> >
> >         if (ring->bf_enabled && desc_size <= MAX_BF && !bounce &&
> >             !vlan_tx_tag_present(skb) && send_doorbell) {
> 
> This patch is good,
> 
> but I've been thinking more about bf+xmit_more and want
> to double check my understanding in that scenario:
> xmit_more=true will queue descriptors normally and
> the last xmit_more=false packet will write into BF.
> I guess BF suppose to pick up the earlier ones from
> the queue, otherwise the whole thing is broken.
> So if indeed BF can pick up the whole chain, then
> it should be the faster way than doing iowrite32(), right?
> --


Right, this is what my patch is doing.

Say we send a burst of 8 packets.

7 first packets are queued, but no iowrite32() is performed.

final packet is queued, and bf is used to send the doorbell.

With our current stack (net-next), its very easy to check :

Disable tso (ethtool -K eth0 tso off)

Then run netperf -t TCP_RR -H ... -- -r 6000,6000

GSO makes great use of skb->xmit_more right now ;)

(Assuming we do not have GSO preparing hundred of segments out of a
single TSO packet)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html