netdev - Re: [PATCHv7 net-next 2/4] sunvnet: make transmit path zero-copy in the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140929.152802.1895227801613062829.davem@davemloft.net>
Date:	Mon, 29 Sep 2014 15:28:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	david.stevens@...cle.com
Cc:	netdev@...r.kernel.org, sowmini.varadhan@...cle.com,
	Raghuram.Kothakota@...cle.com
Subject: Re: [PATCHv7 net-next 2/4] sunvnet: make transmit path zero-copy
 in the kernel

From: David L Stevens <david.stevens@...cle.com>
Date: Mon, 29 Sep 2014 13:44:39 -0400

> @@ -788,12 +874,16 @@ static int vnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  	struct vio_net_desc *d;
>  	unsigned long flags;
>  	unsigned int len;
> -	void *tx_buf;
> -	int i, err;
> +	struct sk_buff *freeskbs = NULL;
> +	int i, err, txi;
> +	void *start = NULL;
> +	int nlen = 0;
> 
>  	if (unlikely(!port))
>  		goto out_dropped;
> 
> +	skb = vnet_skb_shape(skb, &start, &nlen);
> +
>  	spin_lock_irqsave(&port->vio.lock, flags);
> 
>  	dr = &port->vio.drings[VIO_DRIVER_TX_RING];

vnet_skb_shape() can return NULL, I don't think you're handling that case
at all and are blindly derefencing a potentially NULL skb pointer.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html