netdev - RE: [PATCH v2 3/4] ptp: Add PTP_PF_PPS enumeration to ptp_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Sep 2014 09:38:44 +0000
From:	"luwei.zhou@...escale.com" <luwei.zhou@...escale.com>
To:	Richard Cochran <richardcochran@...il.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"Fabio.Estevam@...escale.com" <Fabio.Estevam@...escale.com>,
	"fugang.duan@...escale.com" <fugang.duan@...escale.com>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>
Subject: RE: [PATCH v2 3/4] ptp: Add PTP_PF_PPS enumeration to
 ptp_pin_function.

On Mon, Sep 29, 2014,at 4:56:00PM +0800, Richard Cochran wrote:
> -----Original Message-----
> From: Richard Cochran [mailto:richardcochran@...il.com]
> Sent: Monday, September 29, 2014 4:56 PM
> To: Zhou Luwei-B45643
> Cc: davem@...emloft.net; netdev@...r.kernel.org; shawn.guo@...aro.org;
> bhutchings@...arflare.com; Estevam Fabio-R49496; Duan Fugang-B38611; Li
> Frank-B20596; stephen@...workplumber.org
> Subject: Re: [PATCH v2 3/4] ptp: Add PTP_PF_PPS enumeration to
> ptp_pin_function.
> 
> On Sun, Sep 28, 2014 at 12:20:10PM +0800, Luwei Zhou wrote:
> 
> > diff --git a/include/linux/ptp_clock_kernel.h
> > b/include/linux/ptp_clock_kernel.h
> > index 0d8ff3f..2a5ad1c 100644
> > --- a/include/linux/ptp_clock_kernel.h
> > +++ b/include/linux/ptp_clock_kernel.h
> > @@ -49,6 +49,7 @@ struct ptp_clock_request {
> >   * @n_alarm:   The number of programmable alarms.
> >   * @n_ext_ts:  The number of external time stamp channels.
> >   * @n_per_out: The number of programmable periodic signals.
> > + * @n_pps_chan: The number of programmable channles for pps output.
> >   * @n_pins:    The number of programmable pins.
> >   * @pps:       Indicates whether the clock supports a PPS callback.
> >   * @pin_config: Array of length 'n_pins'. If the number of @@ -99,6
> > +100,7 @@ struct ptp_clock_info {
> >  	int n_alarm;
> >  	int n_ext_ts;
> >  	int n_per_out;
> > +	int n_pps_chan;
> 
> We don't need this. There is only *one* PPS channel.
> 
> We only want to select which of 'n_pins' will be the PPS output.
Yes, there is only one PPS out. But this pin can choose one channel from index (0~3). I am trying to use n_pps_chan to be the max channel index check.
I am a little puzzled. The FEC PTP has 4 channel and we output only one PPS signal. User need to tell driver which channel index is used.  In this
Case, n_pins should be 1 or 4?
My understanding is n_pins should be 1 because there is only one PPS output 
> 
> >  	int n_pins;
> >  	int pps;
> >  	struct ptp_pin_desc *pin_config;
> > diff --git a/include/uapi/linux/ptp_clock.h
> > b/include/uapi/linux/ptp_clock.h index f0b7bfe..57ba7e7 100644
> > --- a/include/uapi/linux/ptp_clock.h
> > +++ b/include/uapi/linux/ptp_clock.h
> > @@ -86,6 +86,7 @@ enum ptp_pin_function {
> >  	PTP_PF_EXTTS,
> >  	PTP_PF_PEROUT,
> >  	PTP_PF_PHYSYNC,
> > +	PTP_PF_PPS,
> >  };
> >
> >  struct ptp_pin_desc {
> > --
> > 1.9.1
> >
> 
> Thanks,
> Richard

Thanks,
Luwei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html