netdev - Re: [PATCH v5 02/10] net: pxa168_eth: add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140930142850.GA30288@kwain>
Date:	Tue, 30 Sep 2014 16:28:50 +0200
From:	Antoine Tenart <antoine.tenart@...e-electrons.com>
To:	David Miller <davem@...emloft.net>
Cc:	antoine.tenart@...e-electrons.com, sebastian.hesselbarth@...il.com,
	alexandre.belloni@...e-electrons.com,
	thomas.petazzoni@...e-electrons.com, zmxu@...vell.com,
	jszhang@...vell.com, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 02/10] net: pxa168_eth: add device tree support

David,

On Mon, Sep 29, 2014 at 04:04:36PM -0400, David Miller wrote:
> From: Antoine Tenart <antoine.tenart@...e-electrons.com>
> Date: Fri, 26 Sep 2014 16:33:48 +0200
> 
> > @@ -1603,6 +1620,12 @@ static int pxa168_eth_suspend(struct platform_device *pdev, pm_message_t state)
> >  #define pxa168_eth_suspend NULL
> >  #endif
> >  
> > +static const struct of_device_id pxa168_eth_of_match[] = {
> > +	{ .compatible = "marvell,pxa168-eth" },
> > +	{ },
> > +};
> > +MODULE_DEVICE_TABLE(of, pxa168_eth_of_match)
> > +
> >  static struct platform_driver pxa168_eth_driver = {
> 
> You didn't even compile test this change with module support enabled.
> 
> drivers/net/ethernet/marvell/pxa168_eth.c:1670:1: error: expected ‘,’ or ‘;’ before ‘static’
> 
> MODULE_DEVICE_TABLE() must be completed with a trailing ';'

Oops, thanks for spotting this!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html