netdev - Re: [PATCH net-next 07/10] r8169:change function name of function "rtl_w1w0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140930223707.GB27610@electric-eye.fr.zoreil.com>
Date:	Wed, 1 Oct 2014 00:37:07 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Chun-Hao Lin <hau@...ltek.com>
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 07/10] r8169:change function name of function
 "rtl_w1w0_eri"

Chun-Hao Lin <hau@...ltek.com> :
> Change the name of this function to "rtl_w0_w1_eri".
> It is more suitable for this function's behavior.

Afaiks it used to follow the same rule as the one I outlined in the
comment to #6/10 for rtl_w0_w1_phy.

Could you elaborate (or say so if it should be clear for me after
some sleep) ?

[...]
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index e68fe5e..e79def5 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
[...]
> @@ -1629,14 +1629,14 @@ static void __rtl8169_set_wol(struct rtl8169_private *tp, u32 wolopts)
>  	case RTL_GIGA_MAC_VER_48:
>  		tmp = ARRAY_SIZE(cfg) - 1;
>  		if (wolopts & WAKE_MAGIC)
> -			rtl_w1w0_eri(tp,
> +			rtl_w0w1_eri(tp,
>  				     0x0dc,
>  				     ERIAR_MASK_0100,
>  				     MagicPacket_v2,
>  				     0x0000,
>  				     ERIAR_EXGMAC);
>  		else
> -			rtl_w1w0_eri(tp,
> +			rtl_w0w1_eri(tp,
>  				     0x0dc,
>  				     ERIAR_MASK_0100,
>  				     0x0000,

Please turn these into:

			rtl_..._eri(tp, 0x0dc, ERIAR_MASK_0100, MagicPacket_v2,
 				    0x0000, ERIAR_EXGMAC);

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html