netdev - Re: [net-next PATCH v3 3/4] net: sched: restrict use of qstats qlen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140930.010306.274182520689361087.davem@davemloft.net>
Date:	Tue, 30 Sep 2014 01:03:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	john.fastabend@...il.com
Cc:	xiyou.wangcong@...il.com, jhs@...atatu.com, eric.dumazet@...il.com,
	netdev@...r.kernel.org
Subject: Re: [net-next PATCH v3 3/4] net: sched: restrict use of qstats qlen

From: John Fastabend <john.fastabend@...il.com>
Date: Sun, 28 Sep 2014 11:53:57 -0700

> This removes the use of qstats->qlen variable from the classifiers
> and makes it an explicit argument to gnet_stats_copy_queue().
> 
> The qlen represents the qdisc queue length and is packed into
> the qstats at the last moment before passnig to user space. By
> handling it explicitely we avoid, in the percpu stats case, having
> to figure out which per_cpu variable to put it in.
> 
> It would probably be best to remove it from qstats completely
> but qstats is a user space ABI and can't be broken. A future
> patch could make an internal only qstats structure that would
> avoid having to allocate an additional u32 variable on the
> Qdisc struct. This would make the qstats struct 128bits instead
> of 128+32.
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html