| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1412150148-9991-3-git-send-email-azhou@nicira.com> Date: Wed, 1 Oct 2014 00:55:47 -0700 From: Andy Zhou <azhou@...ira.com> To: davem@...emloft.net Cc: netdev@...r.kernel.org, Andy Zhou <azhou@...ira.com> Subject: [datapath minor fixes 2/3] datapath: avoid double free routing entry in vxlan_port xmit Route entry will be free on error by vport when freeing skb. additional error check and free after xmit() will cause double free. Signed-off-by: Andy Zhou <azhou@...ira.com> --- datapath/vport-vxlan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/datapath/vport-vxlan.c b/datapath/vport-vxlan.c index 8689853..44968d0 100644 --- a/datapath/vport-vxlan.c +++ b/datapath/vport-vxlan.c @@ -180,8 +180,6 @@ static int vxlan_tnl_send(struct vport *vport, struct sk_buff *skb) tun_key->ipv4_ttl, df, src_port, dst_port, htonl(be64_to_cpu(tun_key->tun_id) << 8)); - if (err < 0) - ip_rt_put(rt); error: return err; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists