netdev - Re: [PATCH] net: xilinx: Remove unnecessary ether_setup after alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <542BBA81.2000406@monstr.eu>
Date:	Wed, 01 Oct 2014 10:25:37 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Michal Simek <michal.simek@...inx.com>,
	linux-kernel@...r.kernel.org
CC:	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>,
	Anirudha Sarangi <anirudh@...inx.com>,
	John Linn <John.Linn@...inx.com>,
	"David S. Miller" <davem@...emloft.net>,
	Manuel Schölling <manuel.schoelling@....de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Joe Perches <joe@...ches.com>,
	Ricardo Ribalda <ricardo.ribalda@...il.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] net: xilinx: Remove unnecessary ether_setup after alloc_etherdev

On 10/01/2014 08:00 AM, Michal Simek wrote:
> From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>
> 
> Calling ether_setup is redundant since alloc_etherdev calls it.
> 
> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> 
>  drivers/net/ethernet/xilinx/ll_temac_main.c       | 1 -
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
> index fda5891835d4..629077050fce 100644
> --- a/drivers/net/ethernet/xilinx/ll_temac_main.c
> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
> @@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device *op)
>  	if (!ndev)
>  		return -ENOMEM;
> 
> -	ether_setup(ndev);
>  	platform_set_drvdata(op, ndev);
>  	SET_NETDEV_DEV(ndev, &op->dev);
>  	ndev->flags &= ~IFF_MULTICAST;  /* clear multicast */
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index c8fd94133ecd..4ea2d4e6f1d1 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1485,7 +1485,6 @@ static int axienet_of_probe(struct platform_device *op)
>  	if (!ndev)
>  		return -ENOMEM;
> 
> -	ether_setup(ndev);
>  	platform_set_drvdata(op, ndev);
> 
>  	SET_NETDEV_DEV(ndev, &op->dev);
> --
> 1.8.2.3
> 

Please ignore this one it is already applied for axienet.
Will send v2 just for ll_temac.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)