[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141002084820.GF6390@secunet.com>
Date: Thu, 2 Oct 2014 10:48:20 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Jiri Pirko <jiri@...nulli.us>
CC: Stephen Hemminger <stephen@...workplumber.org>,
<netdev@...r.kernel.org>
Subject: Re: [PATCH 1/2] iproute2: Add support for IPv6 VTI tunnels to
ip6tunnel
On Thu, Oct 02, 2014 at 10:41:09AM +0200, Jiri Pirko wrote:
> Fri, Sep 26, 2014 at 09:10:56AM CEST, steffen.klassert@...unet.com wrote:
> >
> >@@ -459,11 +462,14 @@ static int do_add(int cmd, int argc, char **argv)
> > switch (p.proto) {
> > case IPPROTO_IPIP:
> > case IPPROTO_IPV6:
> >+ if (p.i_flags != VTI_ISVTI)
> >+ return tnl_add_ioctl(cmd, "ip6_vti0", p.name, &p);
> ^ Wouldn't it be more
> consistent to not to use
> the underscore?
The ipv4 version of vti uses ip_vti0, so I tried to be consistent
with that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists