[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20141003.130305.2216770567363258603.davem@davemloft.net>
Date: Fri, 03 Oct 2014 13:03:05 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: mwelling@...e.org
Cc: tony@...mide.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:ethernet:davinci_emac.c:Fixes flaw in mac
address handling.
From: Michael Welling <mwelling@...e.org>
Date: Wed, 1 Oct 2014 21:32:05 -0500
> The code currently checks the mac_addr variable that is clearly
> zero'd out during allocation.
>
> Further code is added to bring the mac_addr from the partial pdata.
>
> Signed-off-by: Michael Welling <mwelling@...e.org>
I don't see anyone specifying a MAC address in the partial pdata,
so better to just delete that field.
Even if people did, I am not so sure that the partial pdata should
unconditionally trump an OF provided MAC address.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists