netdev - Re: [PATCH net-next] r8152: nway reset after setting eee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141003.150807.1695488392631084970.davem@davemloft.net>
Date:	Fri, 03 Oct 2014 15:08:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hayeswang@...ltek.com
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next] r8152: nway reset after setting eee

From: Hayes Wang <hayeswang@...ltek.com>
Date: Thu, 2 Oct 2014 16:01:22 +0800

> @@ -3480,6 +3480,9 @@ rtl_ethtool_set_eee(struct net_device *net, struct ethtool_eee *edata)
>  
>  	ret = tp->rtl_ops.eee_set(tp, edata);
>  
> +	if (ret == 0)
> +		ret = mii_nway_restart(&tp->mii);

Please test this canonically as "if (!ret)" and delete the empty line between the function
call and the return value test.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html