[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1412346147.3247.97.camel@joe-AO725>
Date: Fri, 03 Oct 2014 07:22:27 -0700
From: Joe Perches <joe@...ches.com>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: Andy Whitcroft <apw@...onical.com>,
Andrew Morton <akpm@...ux-foundation.org>,
netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
gregkh@...uxfoundation.org
Subject: Re: [patch] checkpatch: remove the ether_addr_copy warning
On Fri, 2014-10-03 at 12:35 +0300, Dan Carpenter wrote:
> Most people sending checkpatch.pl fixes don't know how to verify the
> alignment. This checkpatch warning just encourages newbies to try
> introduce bugs. Patch submitters tell us that they just sed the code
> and it's the job for the maintainer to check that it's correct.
I haven't seen many instances of bad patch submittals
on netdev. Is this mostly an issue for staging?
Maybe a downgrade to CHK requiring --strict is OK.
> If you want to work on these then you can get the same information by
> typing `grep -nw memcpy drivers/net/ -R | grep ETH_ALEN`
That's not much of an argument for or against anything in
checkpatch as every operation done by it can be reproduced
by a series of grep operations.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists