netdev - Re: [PATCH v1 2/2] net: sched: replace ematch calls to use struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 03 Oct 2014 17:19:19 -0700
From:	John Fastabend <john.r.fastabend@...el.com>
To:	Cong Wang <cwang@...pensource.com>,
	John Fastabend <john.fastabend@...il.com>
CC:	Cong Wang <xiyou.wangcong@...il.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v1 2/2] net: sched: replace ematch calls to use struct
 net

On 10/03/2014 03:40 PM, Cong Wang wrote:
> On Thu, Oct 2, 2014 at 10:46 PM, John Fastabend
> <john.fastabend@...il.com> wrote:
>> diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
>> index 81ddfa6..f37e4fb 100644
>> --- a/net/sched/cls_basic.c
>> +++ b/net/sched/cls_basic.c
>> @@ -32,7 +32,7 @@ struct basic_filter {
>>         struct tcf_exts         exts;
>>         struct tcf_ematch_tree  ematches;
>>         struct tcf_result       res;
>> -       struct tcf_proto        *tp;
>> +       struct net              *net;
>>         struct list_head        link;
>>         struct rcu_head         rcu;
>>  };
> 
> I guess storing this net pointer to struct tcf_ematch_tree is better,
> since it is only used by ematch?

Sure, that is fine. It is used by em_ipset and three classifiers. It
does simplify the API slightly if its in tcf_ematch, I guess. So I'll 
move it there.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html